Wireshark-commits: [Wireshark-commits] master-2.2 59941af: CIP: Minor bug fixes

Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 30 Sep 2016 23:52:08 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=59941af3fa2a026eb52ba5ec4d1521bcc7801922
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

59941af by D. Ulis (daulis0@xxxxxxxxx):

    CIP: Minor bug fixes
    
    1. CIP: dissect_cip_set_attribute_list_req - Too many bytes highlighted. Could cause malformed packet
    2. CIP: dissect_cip_cco_all_attribute_common - Too many bytes highlighted
    3. CIP Motion: dissect_cntr_service - Wrong size passed in which tried to highlight too many bytes. Would cause malformed packet.
    4. CIP: Some minor formatting/whitespace changes.
    
    Change-Id: I5899888a3e58452945c8546cf635768cdd3cf738
    Reviewed-on: https://code.wireshark.org/review/18000
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit 0f18087ca32fa897dd3dfc04202bb40d3639364d)
    Reviewed-on: https://code.wireshark.org/review/18004
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    

Actions performed:

    from  4768855   NetFlow: Fix a preference description.
    adds  59941af   CIP: Minor bug fixes


Summary of changes:
 epan/dissectors/packet-cip.c       |   59 ++++++++++++++++++------------------
 epan/dissectors/packet-cipmotion.c |   58 +++++++++++++++++++----------------
 2 files changed, 62 insertions(+), 55 deletions(-)