Wireshark-commits: [Wireshark-commits] master e239f72: ISAKMP: Rename identifiers and change item l

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 27 Sep 2016 03:44:40 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e239f72585896f301c2a23312f94cfc50e421aed
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e239f72 by Mirko Parthey (mirko.parthey@xxxxxx):

    ISAKMP: Rename identifiers and change item labels
    
    Rename identifiers and change item labels to reflect their purpose:
    * ISAKMP Phase 1 = IKE
    * ISAKMP Phase 2 = IPsec
    * IKEv2 Attribute = Transform Attribute
    Remove "transform" and "type" where they do not apply.
    
    External users of isakmp.tf.* field names, such as display filters,
    have to be updated after this commit to use isakmp.ipsec.* instead.
    
    old                                     new
    --------------------------------------------------------------------
    dissect_transform_attribute()           dissect_ipsec_attribute()
    dissect_transform_ike_attribute()       dissect_ike_attribute()
    
    ISAKMP_                                 IPSEC_
    
    hf_isakmp_tf_attr                       hf_isakmp_ipsec_attr
    isakmp.tf.                              isakmp.ipsec.
    
    transform_ike_attr_type                 ike_attr_type
    transform_isakmp_attr_type              ipsec_attr_type
    transform_attr_sa_life_type             attr_life_type
    transform_dh_group_type                 dh_group
    transform_attr_encap_type               ipsec_attr_encap_mode
    transform_attr_auth_type                ipsec_attr_auth_algo
    transform_attr_ecn_type                 ipsec_attr_ecn_tunnel
    transform_attr_ext_seq_nbr_type         ipsec_attr_ext_seq_nbr
    transform_attr_addr_preservation_type   ipsec_attr_addr_preservation
    transform_attr_sa_direction_type        ipsec_attr_sa_direction
    transform_attr_enc_type                 ike_attr_enc_algo
    transform_attr_hash_type                ike_attr_hash_algo
    transform_attr_authmeth_type            ike_attr_authmeth
    transform_attr_grp_type                 ike_attr_grp_type
    
    Type Payload                            Payload
    Transform IKE Attribute Type            IKE Attribute
    Transform Attribute Type                IPsec Attribute
    Transform IKE2 Attribute Type           Transform Attribute
    Config Attribute Type                   Config Attribute
    ISAKMP (v1)                             IKEv1
    ISAKMP (v2)                             IKEv2
    --------------------------------------------------------------------
    
    Change-Id: Ib02a0bad100f932a290cae35ea4bd75b191f797b
    Reviewed-on: https://code.wireshark.org/review/17914
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  1a384ef   [proto.c] Add proto_find_first_finfo() to find first occurance of a field.
    adds  e239f72   ISAKMP: Rename identifiers and change item labels


Summary of changes:
 epan/dissectors/packet-isakmp.c |  410 ++++++++++++++++++++-------------------
 1 file changed, 208 insertions(+), 202 deletions(-)