Wireshark-commits: [Wireshark-commits] master 79ae8c1: Report failure to compile a filter as an err

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 25 Sep 2016 18:03:32 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=79ae8c1d07fe777a175269ed49d2adee9c1d575b
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

79ae8c1 by Guy Harris (guy@xxxxxxxxxxxx):

    Report failure to compile a filter as an error.
    
    The NCP dissector relies on those filters being compiled, and we end up
    doing a g_assert() anyway; use g_error() to make sure the error gets
    printed.
    
    Change-Id: Ibc20407c1c08f0baaa626f269e9552ae11b36083
    Ping-Bug: 12945
    Reviewed-on: https://code.wireshark.org/review/17921
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  f3fede0   [iscsi] Add a cast "packet-iscsi.c(625): warning C4267: 'function' : conversion from 'size_t' to 'guint', possible loss of data"
    adds  79ae8c1   Report failure to compile a filter as an error.


Summary of changes:
 epan/dissectors/packet-ncp2222.inc |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)