Wireshark-commits: [Wireshark-commits] master-2.2 355b56b: BTL2AP: compare strings with strcmp, not

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 21 Sep 2016 11:27:25 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=355b56b1c6c545072ac0c1225730b526c6749f0a
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

355b56b by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    BTL2AP: compare strings with strcmp, not memcp
    
    Otherwise a string shorter than 7 characters will trigger an out of bounds access
    
    Bug: 12825
    Change-Id: I54a7909d74838dcb56583374e5753f877ff74fe2
    Reviewed-on: https://code.wireshark.org/review/17826
    Reviewed-by: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    (cherry picked from commit 7be73201a044e8228de8e91a5f8708ebcd761015)
    Reviewed-on: https://code.wireshark.org/review/17828
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  23e8ae4   Qt: reenable export packet bytes menu while capturing
    adds  355b56b   BTL2AP: compare strings with strcmp, not memcp


Summary of changes:
 epan/dissectors/packet-btl2cap.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)