Wireshark-commits: [Wireshark-commits] master d7fe514: Improve support for single-character fields

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 19 Sep 2016 02:51:35 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d7fe514fc05e95e3a99fd211768de5abdc3f6486
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d7fe514 by Guy Harris (guy@xxxxxxxxxxxx):

    Improve support for single-character fields and filter expressions.
    
    Add an FT_CHAR type, which is like FT_UINT8 except that the value is
    displayed as a C-style character constant.
    
    Allow use of C-style character constants in filter expressions; they can
    be used in comparisons with all integral types, and in "contains"
    operators.
    
    Use that type for some fields that appear (based on the way they're
    displayed, or on the use of C-style character constants in their
    value_string tables) to be 1-byte characters rather than 8-bit numbers.
    
    Change-Id: I39a9f0dda0bd7f4fa02a9ca8373216206f4d7135
    Reviewed-on: https://code.wireshark.org/review/17787
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  630b646   WiX: Add NSIS installer checks.
    adds  d7fe514   Improve support for single-character fields and filter expressions.


Summary of changes:
 debian/libwireshark0.symbols           |    2 +
 doc/README.dissector                   |   22 +-
 doc/wireshark-filter.pod               |   12 +-
 epan/dfilter/grammar.lemon             |    5 +
 epan/dfilter/scanner.l                 |   60 ++++-
 epan/dfilter/semcheck.c                |   72 +++++-
 epan/dfilter/sttype-string.c           |    9 +
 epan/dfilter/syntax-tree.h             |    1 +
 epan/dissectors/packet-alljoyn.c       |    4 +-
 epan/dissectors/packet-beep.c          |    4 +-
 epan/dissectors/packet-bzr.c           |    8 +-
 epan/dissectors/packet-dcerpc.c        |   20 ++
 epan/dissectors/packet-dcerpc.h        |    4 +
 epan/dissectors/packet-eap.c           |   12 +-
 epan/dissectors/packet-gdb.c           |   10 +-
 epan/dissectors/packet-ged125.c        |    8 +-
 epan/dissectors/packet-gopher.c        |    4 +-
 epan/dissectors/packet-gsm_a_dtap.c    |    6 +-
 epan/dissectors/packet-ipx.c           |    2 +-
 epan/dissectors/packet-nasdaq-itch.c   |   20 +-
 epan/dissectors/packet-nasdaq-soup.c   |    8 +-
 epan/dissectors/packet-ouch.c          |  340 ++++-----------------------
 epan/dissectors/packet-rtpproxy.c      |   28 +--
 epan/dissectors/packet-soupbintcp.c    |   47 +---
 epan/dissectors/packet-telnet.c        |   18 +-
 epan/dissectors/packet-ucp.c           |   62 ++---
 epan/dissectors/packet-usb.c           |    6 +-
 epan/dissectors/x11-fields             |    4 +-
 epan/dissectors/x11-glx-render-enum.h  |   23 +-
 epan/dissectors/x11-register-info.h    |    4 +-
 epan/ftypes/ftype-integer.c            |  398 ++++++++++++++++++++++++++-----
 epan/ftypes/ftypes.h                   |    3 +-
 epan/proto.c                           |  404 ++++++++++++++++++++++++++++++--
 epan/to_str.c                          |    6 +
 epan/to_str.h                          |   11 +
 plugins/profinet/packet-dcerpc-pn-io.c |    4 +-
 36 files changed, 1113 insertions(+), 538 deletions(-)