URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=66203b4f31e69187636d2dfc0562bc0ccc5a7173
Submitter: Roland Knall (rknall@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
66203b4 by Pascal Quantin (pascal.quantin@xxxxxxxxx):
extcap: fix management of multicheck and saved non boolean arguments
Launching USBPcap without going in the interface options menu exhibits 2 bugs:
- we should restore a value only if it is not an empty string (otherwise USBPcap with an ampty --devices multicheck argument)
- when building the argument list for a non boolean argument not using the default value, do not call g_strconcat. It will
build a string concatenating the option and value (for example "--devices 1" that will be treated as a single argument).
Instead option and value must be given separately to argument list.
Bug: 12846
Change-Id: I5628cb264a7632089e6579e9ae7400e2c0e500e2
Reviewed-on: https://code.wireshark.org/review/17773
Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
Actions performed:
from a978ad7 update bacapp vendor id to name mapping from BACnet
adds 66203b4 extcap: fix management of multicheck and saved non boolean arguments
Summary of changes:
extcap.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)