Wireshark-commits: [Wireshark-commits] master 6519f8e: OCFS2: dissector incorrectly parses LVB data

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 8 Sep 2016 21:01:58 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6519f8e4e81d838e49bf4e4cef179f968378f62d
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

6519f8e by Makoto Shimamura (makoto.shimamura@xxxxxxxxxxxxx):

    OCFS2: dissector incorrectly parses LVB data and claims malformed message
    
    Some messages related to LVB data are mistakenly treated as malformed.
    This patch fixes it by checking LVB flags before parsing LVB data.
    I found that "Convert lock" and "Unlock" use PUT_LVB flags, but "Proxy AST" uses GET_LVB flags.
    
    Ping-Bug: 12122
    Change-Id: I2c62c8cc9f9bd84abaf92de9f216550101962520
    Reviewed-on: https://code.wireshark.org/review/17532
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  bd45929   extcap_child_watch_cb() always uses the status argument.
    adds  6519f8e   OCFS2: dissector incorrectly parses LVB data and claims malformed message


Summary of changes:
 epan/dissectors/packet-ocfs2.c |   72 +++++++++++++++++++++++++---------------
 1 file changed, 46 insertions(+), 26 deletions(-)