Wireshark-commits: [Wireshark-commits] master c8869f6: OK, it probably crashed in proto_initialize_
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 31 Aug 2016 07:41:03 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c8869f68db6cd1d4a341d57600ecf22627632c9f Submitter: Guy Harris (guy@xxxxxxxxxxxx) Changed: branch: master Repository: wireshark Commits: c8869f6 by Guy Harris (guy@xxxxxxxxxxxx): OK, it probably crashed in proto_initialize_all_prefixes(). Remove the debugging printouts. The changes that were committed between the last build that didn't crash and the first build that did were: commit 961f743d69b323aa217a6b39184485d6a0bfb2d5 Author: Peter Wu <peter@xxxxxxxxxxxxx> Date: Mon Aug 29 01:34:22 2016 +0200 xml: fix some memleaks No more memleaks reported for the attachment in bug 12790 :-) Change-Id: I8472e442143b332edfacdf9ef3b8b893f1ec4386 Ping-Bug: 12790 Reviewed-on: https://code.wireshark.org/review/17365 Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx> Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx> Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx> commit a04b6fcb3db901734ed948134c973996786be8b7 Author: Peter Wu <peter@xxxxxxxxxxxxx> Date: Sun Aug 28 22:19:29 2016 +0200 diameter: fix 400kb leaked memory on exit Before: SUMMARY: AddressSanitizer: 399684 byte(s) leaked in 17208 allocation(s). After addressing to-do by calling ddict_free: SUMMARY: AddressSanitizer: 3024 byte(s) leaked in 256 allocation(s). After fixing all remaining leaks cases in the flex file for diameter: SUMMARY: AddressSanitizer: 735 byte(s) leaked in 58 allocation(s). Not bad huh :-) Ping-Bug: 12790 Change-Id: I0c730ad77ae15c69390bc6cf0a3a985395a64771 Reviewed-on: https://code.wireshark.org/review/17364 Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx> Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx> Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx> commit 14312835c63a3e2ec9d311ed1ffee5285141f4f9 Author: Peter Wu <peter@xxxxxxxxxxxxx> Date: Sun Aug 28 19:20:59 2016 +0200 pcapng: do not leak blocks pcapng_open and pcapng_read have 'wblock' allocated on the stack, so if they return, they do not have to set wblock.block to NULL. pcapng_read_block always sets wblock->block to NULL and may initialize it for SHB, IDB, NRB and ISB. Be sure to release the memory for IDB and ISB. It is better to have more wtap_block_free calls on a NULL value than missing them as this would be a memleak (on the other hand, do not release memory that is stored elsewhere such as SHB and NRB). Ping-Bug: 12790 Change-Id: I081f841addb36f16e3671095a919d357f4bc16c5 Reviewed-on: https://code.wireshark.org/review/17362 Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx> Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx> *If* one of those is the cause, my guess is that it's the Diameter one, as the crash happens before any file is read (so it's probably not the pcapng one) and thus before any dissection is done (so it's probably not the XML dissector one). Change-Id: I816c1bbd6078eab251efd02ebb7c3195f6dd1483 Reviewed-on: https://code.wireshark.org/review/17411 Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx> Actions performed: from 1178ee6 GTP: patch for Target identification for non-compliance workaround adds c8869f6 OK, it probably crashed in proto_initialize_all_prefixes(). Summary of changes: epan/proto.c | 2 -- 1 file changed, 2 deletions(-)
- Prev by Date: [Wireshark-commits] wireshark-win64-libs rev 449: /tags/2016-08-31/
- Next by Date: [Wireshark-commits] master 5fea2b5: Revert "diameter: fix 400kb leaked memory on exit"
- Previous by thread: [Wireshark-commits] wireshark-win64-libs rev 449: /tags/2016-08-31/
- Next by thread: [Wireshark-commits] master 5fea2b5: Revert "diameter: fix 400kb leaked memory on exit"
- Index(es):