URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=640382c74364f61da36bdc5b1272e8cda28f1d8f
Submitter: João Valverde (j@xxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
640382c by João Valverde (joao.valverde@xxxxxxxxxxxxxxxxxx):
CMake: Allow setting per target compiler warnings
Setting our compiler warning flags in CMAKE_C_FLAGS does not allow
using different flags per target.
Allow for that possibility by setting the internal WS_WARNINGS_{C,CXX}_FLAGS
and using the COMPILE_OPTIONS property to set them.
This change is just setting mechanism and there should be no difference
in generated warnings.
The check_X_compiler_flag cmake test is changed to test each flag individually.
We need a list, not a space separated string, and the aggregate test is not
significant.
Change-Id: I59fc5cd7e130c7a5e001c598e3df3e13f83a6a25
Reviewed-on: https://code.wireshark.org/review/17150
Petri-Dish: João Valverde <j@xxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: João Valverde <j@xxxxxx>
Actions performed:
from 505bcefd isakmp Fix IKEv2 modification UAT crash
adds 640382c CMake: Allow setting per target compiler warnings
Summary of changes:
CMakeLists.txt | 88 +++++++++++++++++++++++------------
capchild/CMakeLists.txt | 1 +
caputils/CMakeLists.txt | 1 +
cmake/modules/WiresharkPlugin.cmake | 1 +
codecs/CMakeLists.txt | 1 +
echld/CMakeLists.txt | 1 +
epan/CMakeLists.txt | 4 ++
epan/crypt/CMakeLists.txt | 1 +
epan/dfilter/CMakeLists.txt | 1 +
epan/dissectors/CMakeLists.txt | 2 +
epan/ftypes/CMakeLists.txt | 1 +
epan/nghttp2/CMakeLists.txt | 1 +
epan/wmem/CMakeLists.txt | 2 +
epan/wslua/CMakeLists.txt | 1 +
file.c | 4 +-
randpkt_core/CMakeLists.txt | 1 +
tools/lemon/CMakeLists.txt | 1 +
ui/CMakeLists.txt | 1 +
ui/gtk/CMakeLists.txt | 1 +
ui/qt/CMakeLists.txt | 1 +
wiretap/CMakeLists.txt | 1 +
writecap/CMakeLists.txt | 1 +
wsutil/CMakeLists.txt | 1 +
23 files changed, 86 insertions(+), 32 deletions(-)