Wireshark-commits: [Wireshark-commits] master ff00166: Fix handling of parameters with no value.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 23 Aug 2016 02:29:14 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ff00166a96d887e03899577caae3a355c26b0837
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ff00166 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix handling of parameters with no value.
    
    Return a value length of 0 if there's no parameter value.
    
    (And don't return anything if the pointers through which we return them
    are null.)
    
    If no value is present, return NULL from ws_find_media_type_parameter().
    
    Change-Id: I32b57623d7651bcf065af5b81f2390a600988b21
    Reviewed-on: https://code.wireshark.org/review/17255
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  4458c48   Add cast to squelch "building with a C++ compiler" warnings.
    adds  ff00166   Fix handling of parameters with no value.


Summary of changes:
 epan/media_params.c |   15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)