Wireshark-commits: [Wireshark-commits] master 5825f59: Pass an HTTP message type to all HTTP subdis

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 22 Aug 2016 06:34:32 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5825f59ddccb8af2b4a06356f61195dd26c977d7
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5825f59 by Guy Harris (guy@xxxxxxxxxxxx):

    Pass an HTTP message type to all HTTP subdissectors.
    
    This gets complicated, because those subdissectors might be called by
    other dissectors as well.  We need a better way of passing that sort of
    out-of-bound information.
    
    Pull some routines used for processing Content-Type parameters into
    common code; we can't guarantee that the media parameters passed in
    would be writable (passing it as *the* data hid that; passing a
    structure with that *and* the HTTP message type revealed it), so don't
    convert it to lower-case in place.
    
    Use that information, if available, to determine whether an IPP message
    is a requet or a response.
    
    Change-Id: I4bccc9f05cd0b14ad445be7ab37b3d884d841325
    Reviewed-on: https://code.wireshark.org/review/17216
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  efdcb25   ISUP: Enhance display of unknown (opt) parameter
    adds  5825f59   Pass an HTTP message type to all HTTP subdissectors.


Summary of changes:
 epan/CMakeLists.txt                      |    1 +
 epan/Makefile.am                         |    2 +
 epan/dissectors/packet-http-urlencoded.c |   15 +++-
 epan/dissectors/packet-http.c            |   25 +++---
 epan/dissectors/packet-http.h            |   13 +++
 epan/dissectors/packet-imf.c             |    7 +-
 epan/dissectors/packet-ipp.c             |   24 ++++-
 epan/dissectors/packet-isup.c            |   59 +++++++-----
 epan/dissectors/packet-json.c            |   15 +++-
 epan/dissectors/packet-jxta.c            |    9 +-
 epan/dissectors/packet-media.c           |    8 +-
 epan/dissectors/packet-msrp.c            |    7 +-
 epan/dissectors/packet-multipart.c       |  143 +++++++-----------------------
 epan/dissectors/packet-sip.c             |   10 ++-
 epan/dissectors/packet-spdy.c            |   16 +++-
 epan/dissectors/packet-text-media.c      |   14 ++-
 epan/media_params.c                      |  133 +++++++++++++++++++++++++++
 wsutil/crc8.h => epan/media_params.h     |   30 ++++---
 18 files changed, 344 insertions(+), 187 deletions(-)
 create mode 100644 epan/media_params.c
 copy wsutil/crc8.h => epan/media_params.h (62%)