Wireshark-commits: [Wireshark-commits] master c06da45: Add a preference to byte-swap the CAN ID fie

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 19 Aug 2016 23:19:36 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c06da45f3cea0263cfe2a02ee4294b754e5657df
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c06da45 by Guy Harris (guy@xxxxxxxxxxxx):

    Add a preference to byte-swap the CAN ID field.
    
    This can be useful when dealing with 1) captures from versions of
    libpcap without the bug fix to use DLT_CAN_SOCKETCAN_HOSTENDIAN when
    appropriate and 2) DLT_CAN_SOCKETCAN_HOSTENDIAN captures if processed by
    a machine with a different byte order from the capturing machine with
    software that doesn't properly put the field into host byte order when
    reading and writing.
    
    Change-Id: Ia206e5c51aecccf2508cca01cff65a4feb379ac8
    Reviewed-on: https://code.wireshark.org/review/17187
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  22a4f8e   LCSAP: fix indent (use 2 spaces) and modelines
    adds  c06da45   Add a preference to byte-swap the CAN ID field.


Summary of changes:
 epan/dissectors/packet-socketcan.c |   35 ++++++++++++++++++++---------------
 1 file changed, 20 insertions(+), 15 deletions(-)