Wireshark-commits: [Wireshark-commits] master-2.2 2ea7620: Make it a little clearer what ascend_ope

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 18 Aug 2016 01:43:24 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2ea7620b244962c623d334ff2f93a9f2ebe27c5b
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

2ea7620 by Guy Harris (guy@xxxxxxxxxxxx):

    Make it a little clearer what ascend_open() is doing.
    
    Expand comments, and merge two separate if checks.
    
    Change-Id: If339ce632ccc91c425ba6db4a32296c3038253ac
    Reviewed-on: https://code.wireshark.org/review/17128
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 85ebd88083e134304c76af52aa573064e73df19f)
    Reviewed-on: https://code.wireshark.org/review/17129
    

Actions performed:

    from  8727e9c   Just return the value of yyparse() from run_ascend_parser().
    adds  2ea7620   Make it a little clearer what ascend_open() is doing.


Summary of changes:
 wiretap/ascendtext.c |   27 ++++++++++++++++-----------
 1 file changed, 16 insertions(+), 11 deletions(-)