Wireshark-commits: [Wireshark-commits] lts-1.12.1 4efb64c: RLC: fix a stack overflow in rlc_decode_

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 11 Aug 2016 16:41:07 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4efb64c856fbaaa6e078a5efdce4f4fa45891b6c
Submitter: Balint Reczey (balint@xxxxxxxxxxxxxxx)
Changed: branch: lts-1.12.1
Repository: wireshark

Commits:

4efb64c by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    RLC: fix a stack overflow in rlc_decode_li function
    
    The test to check whether the array was full or not was off by 1
    
    Bug: 12664
    Change-Id: If2057b71d92c7f03e05b0f4676abc62d5a03ae73
    Reviewed-on: https://code.wireshark.org/review/16640
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    (cherry picked from commit 47a5fa850b388fcf4ea762073806f01b459820fe)
    Reviewed-on: https://code.wireshark.org/review/16643
    (cherry picked from commit 604b8929f3ca540862de4f539fae848abb78dfb6)
    Reviewed-on: https://code.wireshark.org/review/17019
    Reviewed-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    

Actions performed:

    from  4d84db5   MMSE: remove proto_tree_add_text calls
    adds  4efb64c   RLC: fix a stack overflow in rlc_decode_li function


Summary of changes:
 epan/dissectors/packet-rlc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)