URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=561a2f056bd76bfcb4f89a05542ffce32eed5049
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
561a2f0 by Mirko Parthey (mirko.parthey@xxxxxx):
Fix IKEv1 decryption and initialization vectors
Generate initialization vectors during Wireshark's first pass,
in order to improve reliability and efficiency. (bug #12699)
Remove a dissection shortcut in first pass to allow early analysis
of the transform payloads, which is needed to find out the crypto
algorithms.
Introduce a hash table to store an IV per message ID. (bug #12610)
Fix handling of the initial phase 1 IV. (bug #12620)
Cache IVs as per-packet data instead of a list.
Use the wmem allocator to avoid memory leaks.
Ensure libgcrypt resource cleanup on error paths.
Rely only on IKE attributes to find the decryption algorithm,
do not consider the length of the user-configured secret at this point.
Split code into small functions.
Ping-Bug: 12610
Ping-Bug: 12620
Ping-Bug: 12699
Change-Id: I7137943da42d54816808312cd1716a7e05478cbb
Reviewed-on: https://code.wireshark.org/review/16846
Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from d13f1b0 Add support for PMT parsing of ATSC A/52 Audio stream type and AC-3 descriptor
adds 561a2f0 Fix IKEv1 decryption and initialization vectors
Summary of changes:
epan/dissectors/packet-isakmp.c | 404 +++++++++++++++++++++++----------------
1 file changed, 241 insertions(+), 163 deletions(-)