Wireshark-commits: [Wireshark-commits] master-2.2 8eb7e54: Don't snprintf() into a string with one

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 3 Aug 2016 03:30:52 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8eb7e540eaecb9f4565aa1e6263216717edd8fb6
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

8eb7e54 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't snprintf() into a string with one of the arguments being the same string.
    
    That doesn't work - you could be writing into the string from which
    you're reading.
    
    Bug: 12700
    Change-Id: I70f3ce6048dea582ec5e08c24c99e9a553b352df
    Reviewed-on: https://code.wireshark.org/review/16850
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 6d8261994bb928b7e80e3a2478a3d939ea1ef373)
    Reviewed-on: https://code.wireshark.org/review/16851
    

Actions performed:

    from  57ab1d4   Bugfix endian issues with 802.11 FCS
    adds  8eb7e54   Don't snprintf() into a string with one of the arguments being the same string.


Summary of changes:
 epan/dissectors/asn1/h225/h225.cnf |   44 +++++----
 epan/dissectors/packet-h225.c      |  184 +++++++++++++++++++-----------------
 2 files changed, 126 insertions(+), 102 deletions(-)