Wireshark-commits: [Wireshark-commits] master-2.2 d927db5: RSVP: Wrong order of Attribute Flags TLV

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 30 Jul 2016 20:06:58 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d927db550cfafd642a11f1b00ed7a5b02ed360f3
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

d927db5 by Uli Heilmeier (uh@xxxxxxxxxxxx):

    RSVP: Wrong order of Attribute Flags TLV
    
    According to RFC 5420 Section 3.1 the MSB is bit zero.
    Reported by Alexander Okonnikov.
    
    Bug: 12652
    Change-Id: I9b414464b05ab0724a6560aa441c3f5324130fdb
    Reviewed-on: https://code.wireshark.org/review/16611
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit 4c9f7b56639603a3bc6f97ce5d2e9453485ffb28)
    Reviewed-on: https://code.wireshark.org/review/16788
    

Actions performed:

    from  e11b994   Don't discard unknown coloring rules.
    adds  d927db5   RSVP: Wrong order of Attribute Flags TLV


Summary of changes:
 epan/dissectors/packet-rsvp.c |  111 ++++++++++++++++++++---------------------
 1 file changed, 54 insertions(+), 57 deletions(-)