Wireshark-commits: [Wireshark-commits] master 8b0e9c6: Follow up for proto_tree_add_checksum.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 27 Jul 2016 03:40:20 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8b0e9c66728f6a39bbe3ada1029e13ad1378013a
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8b0e9c6 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Follow up for proto_tree_add_checksum.
    
    Fill in the "gaps" so that all dissectors that verify checksums have both a
    status and expert info field.
    
    Also address comments from original proto_tree_add_checksum patch that didn't make it.
    
    Ping-Bug: 8859
    Change-Id: I2e6640108fd6bb218cb959fe9e4ba98a13e43a2f
    Reviewed-on: https://code.wireshark.org/review/16590
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  b7f1e99   [BTLE] Use the correct struct.
    adds  8b0e9c6   Follow up for proto_tree_add_checksum.


Summary of changes:
 doc/README.dissector                    |   14 ++++++
 epan/dissectors/packet-carp.c           |   24 ++++++++--
 epan/dissectors/packet-cattp.c          |   17 +++++--
 epan/dissectors/packet-cdp.c            |    5 +-
 epan/dissectors/packet-chdlc.c          |    2 +-
 epan/dissectors/packet-clnp.c           |   12 +++--
 epan/dissectors/packet-dccp.c           |    6 ++-
 epan/dissectors/packet-dec-dnart.c      |   21 +++++++--
 epan/dissectors/packet-dmx.c            |   13 +++++-
 epan/dissectors/packet-dvb-s2-bb.c      |   22 ++++++++-
 epan/dissectors/packet-dvmrp.c          |   16 ++++++-
 epan/dissectors/packet-eigrp.c          |    5 +-
 epan/dissectors/packet-epon.c           |    7 ++-
 epan/dissectors/packet-esis.c           |   10 +++-
 epan/dissectors/packet-extreme.c        |    6 ++-
 epan/dissectors/packet-fc.c             |    5 +-
 epan/dissectors/packet-gre.c            |   10 +++-
 epan/dissectors/packet-h223.c           |   14 +++++-
 epan/dissectors/packet-hip.c            |   13 ++++--
 epan/dissectors/packet-icmp.c           |   12 +++--
 epan/dissectors/packet-ieee80211.c      |    9 +++-
 epan/dissectors/packet-igap.c           |   12 ++++-
 epan/dissectors/packet-igmp.c           |   32 ++++++++-----
 epan/dissectors/packet-igmp.h           |    2 +-
 epan/dissectors/packet-isis-hello.c     |   10 ++--
 epan/dissectors/packet-isis-snp.c       |   12 +++--
 epan/dissectors/packet-kingfisher.c     |   16 ++++++-
 epan/dissectors/packet-lmp.c            |   10 ++--
 epan/dissectors/packet-mbtcp.c          |   10 +++-
 epan/dissectors/packet-mrdisc.c         |   18 +++++--
 epan/dissectors/packet-msnip.c          |   20 ++++++--
 epan/dissectors/packet-mtp2.c           |    4 +-
 epan/dissectors/packet-nhrp.c           |   15 ++++--
 epan/dissectors/packet-ositp.c          |   21 +++++++--
 epan/dissectors/packet-pgm.c            |   12 +++--
 epan/dissectors/packet-pim.c            |   40 ++++++++++++----
 epan/dissectors/packet-ppp.c            |   27 +++++++----
 epan/dissectors/packet-ppp.h            |    2 +-
 epan/dissectors/packet-rdm.c            |   16 +++++--
 epan/dissectors/packet-rfid-pn532-hci.c |   25 ++++++----
 epan/dissectors/packet-rgmp.c           |   13 +++++-
 epan/dissectors/packet-synphasor.c      |    8 +++-
 epan/dissectors/packet-sysex.c          |    6 ++-
 epan/dissectors/packet-teamspeak2.c     |   34 ++++++++++----
 epan/dissectors/packet-udp.c            |   11 +++--
 epan/dissectors/packet-v5dl.c           |   18 +++++--
 epan/dissectors/packet-xip-serval.c     |    7 ++-
 epan/dissectors/packet-xtp.c            |   19 +++++---
 epan/dissectors/packet-zrtp.c           |   15 +++++-
 epan/proto.c                            |   28 ++---------
 plugins/irda/packet-sir.c               |   25 ++++++----
 plugins/wimax/mac_hd_generic_decoder.c  |   29 ++++++++++--
 plugins/wimax/msg_dlmap.c               |   78 +++++++++++++++++++++----------
 plugins/wimax/msg_ulmap.c               |   22 ++++++---
 plugins/wimax/wimax_harq_map_decoder.c  |   38 ++++++++++++---
 55 files changed, 673 insertions(+), 225 deletions(-)