URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0590a4f6d82c9eb54621aba50638ecbef78dccee
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
0590a4f by Harald Welte (laforge@xxxxxxxxxxxx):
packet-ehdlc: Update with results from better understanding the protocol
The Ericsson HDLC format inside L2TP is not publicly documented, so when
I originally wrote the code, I was basically just looking at hex-dumps
of protocol traces and trying to ge an initial understanding. By now,
that understanding has significantly matured, so let's update the
dissector accordingly.
The major changes are regarding the understanding that there is not a
message type, but in fact a compressed SAPI and compressed TEI field.
Based on this, we can discriminate on whether there will be a HDLC/LAPD
header to follow, or whether there's actual user data (TRAU frame
replacement) following.
Change-Id: Ic29d2d295678c4dc5f93cd8404b2e832f4532daf
Reviewed-on: https://code.wireshark.org/review/16508
Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
Actions performed:
from baf8f9c Add support for USB3-specific Hub Class Feature Selectors
adds 0590a4f packet-ehdlc: Update with results from better understanding the protocol
Summary of changes:
epan/dissectors/packet-ehdlc.c | 149 ++++++++++++++++++++++++++++------------
1 file changed, 105 insertions(+), 44 deletions(-)