Wireshark-commits: [Wireshark-commits] master 4a60897: sshdump: Change ws_close to closesocket

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 22 Jul 2016 21:59:49 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4a6089795aa3dfcfa9cc2839190b05a10642c63e
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4a60897 by Roland Knall (roland.knall@xxxxxxxxxxxxxxxxx):

    sshdump: Change ws_close to closesocket
    
    ws_close just calls _close(); that doesn't close sockets.  closesocket()
    is the API to close a socket on Windows, and is defined as close()
    on UN*X, so using closesocket() will close sockets on Windows and UN*X.
    
    This way, we close the pipe socket correctly on Windows.
    
    Change-Id: I6d50e26bfabac5618c74a180cbe94d444b591bd4
    Reviewed-on: https://code.wireshark.org/review/16582
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  cf4fc7b   Use ws_printf routines everywhere in column-utils.c.
    adds  4a60897   sshdump: Change ws_close to closesocket


Summary of changes:
 extcap/sshdump.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)