Wireshark-commits: [Wireshark-commits] master 25dfe44: ciscodump.c - Address VS Code Analysis warni

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 17 Jul 2016 13:10:45 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=25dfe445a109bbeaf38e6394f81a3bc2880850a3
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

25dfe44 by Michael Mann (mmann78@xxxxxxxxxxxx):

    ciscodump.c - Address VS Code Analysis warnings.
    
    1. Check sscanf return value
    2. Take large "packet" byte array off of stack and onto heap.
    
    Change-Id: I8ade76359f1b0739ec31d7f3b688d212f21357ba
    Reviewed-on: https://code.wireshark.org/review/16498
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  6e7b1b8   Update to support OUCH-4.2 as of 2016/02/29 release
    adds  25dfe44   ciscodump.c - Address VS Code Analysis warnings.


Summary of changes:
 extcap/ciscodump.c |   15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)