Wireshark-commits: [Wireshark-commits] master ed27ad4: androiddump.c: Use preprocessor directive to

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 14 Jul 2016 07:06:10 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ed27ad491dda85c96d3cbe78c54eff7adf67548f
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ed27ad4 by Michael Mann (mmann78@xxxxxxxxxxxx):

    androiddump.c: Use preprocessor directive to distinguish E_AGAIN and E_WOULDBLOCK.
    
    VS Code analysis considers them hardcoded values so the if statement is either
    always true or always false.
    
    Change-Id: Iad04add9391c515873e2e00d2c6cbd682fbf5b3f
    Reviewed-on: https://code.wireshark.org/review/16419
    Reviewed-by: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    Petri-Dish: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  2c0d117   Fix VHT valid checks.
    adds  ed27ad4   androiddump.c: Use preprocessor directive to distinguish E_AGAIN and E_WOULDBLOCK.


Summary of changes:
 extcap/androiddump.c |   69 +++++++++++++++++++++++++++++++++++++++++++-------
 1 file changed, 60 insertions(+), 9 deletions(-)