Wireshark-commits: [Wireshark-commits] master 1e8ed70: Treat SPI field in ESP/SA configuration as s

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 4 Jul 2016 16:35:09 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1e8ed70e1303148df89bdfe36bb2e620989f5fd9
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1e8ed70 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Treat SPI field in ESP/SA configuration as string only if wildcards are used.
    
    Otherwise convert the SPI field to a number, which allows more user
    flexibility in SPI format.
    
    Bug: 12567
    Change-Id: I646f0aeeeec4ca4302eb7d5172af9218e88b289f
    Reviewed-on: https://code.wireshark.org/review/16248
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  3f80490   NHRP: Add option for source address in authentication extension.
    adds  1e8ed70   Treat SPI field in ESP/SA configuration as string only if wildcards are used.


Summary of changes:
 epan/dissectors/packet-ipsec.c |   36 +++++++++++++++++++++---------------
 1 file changed, 21 insertions(+), 15 deletions(-)