[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2ab415579491e4bc66ea58627bda504cae833b9e
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2ab4155 by Michael Mann (mmann78@xxxxxxxxxxxx):

    tvb_get_string_enc + proto_tree_add_item = proto_tree_add_item_ret_string
    
    Also some other tricks to remove unnecessary tvb_get_string_enc calls.
    
    Change-Id: I2f40d9175b6c0bb0b1364b4089bfaa287edf0914
    Reviewed-on: https://code.wireshark.org/review/16158
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  8c37621   CIP: Cleanup info column for MSP packets
    adds  2ab4155   tvb_get_string_enc + proto_tree_add_item = proto_tree_add_item_ret_string


Summary of changes:
 .../asn1/ansi_map/packet-ansi_map-template.c       |   16 +-
 epan/dissectors/asn1/c1222/packet-c1222-template.c |   10 +-
 epan/dissectors/asn1/gsm_map/gsm_map.cnf           |    6 +-
 epan/dissectors/file-pcapng.c                      |   51 ++--
 epan/dissectors/packet-aastra-aasp.c               |   11 +-
 epan/dissectors/packet-adb_cs.c                    |    6 +-
 epan/dissectors/packet-alljoyn.c                   |  109 +++++----
 epan/dissectors/packet-amqp.c                      |  246 ++++++++++----------
 epan/dissectors/packet-ansi_map.c                  |   22 +-
 epan/dissectors/packet-ar_drone.c                  |    7 +-
 epan/dissectors/packet-artnet.c                    |   35 ++-
 epan/dissectors/packet-bfd.c                       |   23 +-
 epan/dissectors/packet-bitcoin.c                   |    9 +-
 epan/dissectors/packet-bootp.c                     |    7 +-
 epan/dissectors/packet-btavrcp.c                   |    5 +-
 epan/dissectors/packet-bthcrp.c                    |    5 +-
 epan/dissectors/packet-btsdp.c                     |  100 +++-----
 epan/dissectors/packet-c1222.c                     |   16 +-
 epan/dissectors/packet-catapult-dct2000.c          |   12 +-
 epan/dissectors/packet-cell_broadcast.c            |    8 +-
 epan/dissectors/packet-cmpp.c                      |    7 +-
 epan/dissectors/packet-coap.c                      |    6 +-
 epan/dissectors/packet-collectd.c                  |   29 ++-
 epan/dissectors/packet-dcerpc-epm.c                |   18 +-
 epan/dissectors/packet-dcerpc-fileexp.c            |    3 +-
 epan/dissectors/packet-dcerpc-fldb.c               |   55 ++---
 epan/dissectors/packet-dcerpc-rpriv.c              |   10 +-
 epan/dissectors/packet-dcerpc-rs_acct.c            |   12 +-
 epan/dissectors/packet-dcerpc-rs_misc.c            |    5 +-
 epan/dissectors/packet-dcerpc-rs_pgo.c             |   36 ++-
 epan/dissectors/packet-dcerpc-spoolss.c            |   14 +-
 epan/dissectors/packet-dcp-etsi.c                  |   10 +-
 epan/dissectors/packet-dhcp-failover.c             |   21 +-
 epan/dissectors/packet-diameter_3gpp.c             |   16 +-
 epan/dissectors/packet-dis.c                       |   10 +-
 epan/dissectors/packet-dmp.c                       |    5 +-
 epan/dissectors/packet-dnp.c                       |    9 +-
 epan/dissectors/packet-dns.c                       |    5 +-
 epan/dissectors/packet-dtn.c                       |    7 +-
 epan/dissectors/packet-dvbci.c                     |   29 +--
 epan/dissectors/packet-edonkey.c                   |    7 +-
 epan/dissectors/packet-epmd.c                      |   20 +-
 epan/dissectors/packet-erldp.c                     |   13 +-
 epan/dissectors/packet-exported_pdu.c              |   18 +-
 epan/dissectors/packet-extreme.c                   |   14 +-
 epan/dissectors/packet-foundry.c                   |    8 +-
 epan/dissectors/packet-gearman.c                   |    5 +-
 epan/dissectors/packet-gsm_a_dtap.c                |    4 +-
 epan/dissectors/packet-gsm_map.c                   |    6 +-
 epan/dissectors/packet-hpfeeds.c                   |    7 +-
 epan/dissectors/packet-icep.c                      |   15 +-
 epan/dissectors/packet-ieee80211-prism.c           |    5 +-
 epan/dissectors/packet-ieee80211.c                 |   41 ++--
 epan/dissectors/packet-imf.c                       |   25 +-
 epan/dissectors/packet-irc.c                       |   66 +++---
 epan/dissectors/packet-isakmp.c                    |   54 ++---
 epan/dissectors/packet-m2tp.c                      |    5 +-
 epan/dissectors/packet-mikey.c                     |   14 +-
 epan/dissectors/packet-mip6.c                      |   24 +-
 epan/dissectors/packet-ms-mms.c                    |   34 ++-
 epan/dissectors/packet-mswsp.c                     |   31 ++-
 epan/dissectors/packet-mysql.c                     |   11 +-
 epan/dissectors/packet-netflow.c                   |   12 +-
 epan/dissectors/packet-netlink-route.c             |   10 +-
 epan/dissectors/packet-ntlmssp.c                   |   17 +-
 epan/dissectors/packet-obex.c                      |   16 +-
 epan/dissectors/packet-opsi.c                      |   10 +-
 epan/dissectors/packet-pana.c                      |    8 +-
 epan/dissectors/packet-pflog.c                     |   10 +-
 epan/dissectors/packet-ppcap.c                     |    5 +-
 epan/dissectors/packet-pppoe.c                     |   10 +-
 epan/dissectors/packet-ptpip.c                     |   13 +-
 epan/dissectors/packet-quake2.c                    |    6 +-
 epan/dissectors/packet-quic.c                      |   26 ++-
 epan/dissectors/packet-radius.c                    |    5 +-
 epan/dissectors/packet-rpcap.c                     |   13 +-
 epan/dissectors/packet-rsvp.c                      |   16 +-
 epan/dissectors/packet-rtcp.c                      |    4 +-
 epan/dissectors/packet-rtpproxy.c                  |   12 +-
 epan/dissectors/packet-rtps.c                      |   25 +-
 epan/dissectors/packet-s7comm.c                    |   27 +--
 epan/dissectors/packet-sametime.c                  |    3 +-
 epan/dissectors/packet-sbus.c                      |    8 +-
 epan/dissectors/packet-sdp.c                       |  124 ++++------
 epan/dissectors/packet-sip.c                       |    5 +-
 epan/dissectors/packet-smb-pipe.c                  |   10 +-
 epan/dissectors/packet-smb.c                       |   30 ++-
 epan/dissectors/packet-stun.c                      |   46 ++--
 epan/dissectors/packet-tcpros.c                    |   10 +-
 epan/dissectors/packet-tftp.c                      |   25 +-
 epan/dissectors/packet-tnef.c                      |    7 +-
 epan/dissectors/packet-ubertooth.c                 |   16 +-
 epan/dissectors/packet-uma.c                       |    5 +-
 epan/dissectors/packet-v5ua.c                      |   24 +-
 epan/dissectors/packet-vnc.c                       |   15 +-
... 3 lines suppressed ...