Wireshark-commits: [Wireshark-commits] master ea4d01d: The "coding" subfield of the VHT field is a

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 27 Jun 2016 00:38:39 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ea4d01d90eecead750c44b5531f5ec28c95b51c1
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ea4d01d by Guy Harris (guy@xxxxxxxxxxxx):

    The "coding" subfield of the VHT field is a bitmask.
    
    Treat it as such.  Fetch it once, regardless of whether we have any
    non-zero NSS values or not, and use the per-user NSS value to decide
    whether a particular bit in the bitmask is valid and worth displaying.
    
    Make the four coding fields bitfields, with the appropriate bit.
    
    Change-Id: I506b35afa9d07da8d800da5c304d5d0aadd87c54
    Reviewed-on: https://code.wireshark.org/review/16155
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  497159f   Check for an invalid 11ac MCS/bandwidth/NSS combination.
    adds  ea4d01d   The "coding" subfield of the VHT field is a bitmask.


Summary of changes:
 epan/dissectors/packet-ieee80211-radiotap.c |   13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)