Wireshark-commits: [Wireshark-commits] master fb9a7d4: Don't assume we successfully read the config

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 19 Jun 2016 22:29:06 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fb9a7d43cde773a0f006db580c5907dd2c4a4d98
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

fb9a7d4 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't assume we successfully read the configuration files.
    
    read_configuration_files() can fail and return NULL, so check that
    commandline_info.prefs_p is non-null before dereferencing it.
    
    Fixes CID 1362778.
    
    Change-Id: I3066769c474d394fbfe548b50d6be704964e59d3
    Reviewed-on: https://code.wireshark.org/review/16028
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  30919f7   Don't assume we have an array of GeoIP databases.
    adds  fb9a7d4   Don't assume we successfully read the configuration files.


Summary of changes:
 ui/gtk/main.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)