Wireshark-commits: [Wireshark-commits] master b26e757: Let the calculated window scale be 16 bit wi

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 15 Jun 2016 13:05:13 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b26e757b310180bd2ab867dd5ad0cc0261993135
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b26e757 by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    Let the calculated window scale be 16 bit wide.
    
    Even though TCP window scale shift is only 8 bits, the scale
    calculated from it is max 16384. therefor a 16 bit value.
    Let the tree item map to the single byte in the TVB, while
    allowing the value to be 16 bit.
    
    Bug: 12525
    Change-Id: I41cebc62f6b8b09e13efa5f3b7432001e8d994e1
    Reviewed-on: https://code.wireshark.org/review/15914
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  0ef1d94   Allow control of individual columns to be (un)writable.
    adds  b26e757   Let the calculated window scale be 16 bit wide.


Summary of changes:
 epan/dissectors/packet-tcp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)