Wireshark-commits: [Wireshark-commits] master 581a17a: CORBA IDL: compile dissectors with /Ox when

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 14 Jun 2016 21:58:04 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=581a17af40b84ef0c9e7f41ed0795af345b61ce1
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

581a17a by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    CORBA IDL: compile dissectors with /Ox when using MSVC2013 x64
    
    By default Windows files are compiled with /O2 optimization flag (that brings the best performance).
    But MSVC2013 x64 compiler generates buggy code for CORBA IDL dissectors.
    Let's downgrade the optimization to /Ox for those files specifically.
    
    Bug: 12495
    Change-Id: Ibbb532653808d915c82bd20b55dd9e68d86b1207
    Reviewed-on: https://code.wireshark.org/review/15884
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  d74113f   Don't list "AVP" as a possible member of a grouped AVP.
    adds  581a17a   CORBA IDL: compile dissectors with /Ox when using MSVC2013 x64


Summary of changes:
 epan/CMakeLists.txt             |    1 +
 epan/dissectors/CMakeLists.txt  |   27 ++++++++++++++++++++++++---
 epan/dissectors/Makefile.common |    5 +++--
 3 files changed, 28 insertions(+), 5 deletions(-)