URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=24f02dafcd80a10558bf5afeed07a0989a6d7cc6
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
24f02da by Guy Harris (guy@xxxxxxxxxxxx):
Add checks to address setting routines.
Fail if:
1) you have an AT_NONE address with data;
2) you have a non-AT_NONE address with a zero length and a
non-null data pointer, or with a non-zero length and a null
data pointer.
When comparing addresses for equality, just make sure the types are the
same, the lengths are the same and, if the lengths are non-zero, the
data is the same; don't treat AT_NONE specially - the "lengths are
non-zero" check will make sure we do the right thing.
Make sure when we create an AT_NONE address it has a zero length and
null data pointer.
Change-Id: I5c452ef0d140c2d9aef3004f1cfd124a95b78fb2
Reviewed-on: https://code.wireshark.org/review/15839
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
Actions performed:
from 4cab051 Store the tree item to add to later (CID-1159152)
adds 24f02da Add checks to address setting routines.
Summary of changes:
epan/address.h | 47 ++++++++++++++++++++++++++++------------
epan/dissectors/packet-iax2.c | 3 +--
epan/dissectors/packet-sflow.c | 12 +++++-----
ui/gtk/graph_analysis.c | 4 +---
ui/qt/tcp_stream_dialog.cpp | 4 ++--
ui/voip_calls.c | 3 +--
6 files changed, 43 insertions(+), 30 deletions(-)