Wireshark-commits: [Wireshark-commits] master 237f2d4: Qt/Bluetooth: Add Device dialog
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 10 Jun 2016 13:50:56 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=237f2d400669aec77dabfba29c9d4cbbd75d246e Submitter: Michal Labedzki (michal.labedzki@xxxxxxxxx) Changed: branch: master Repository: wireshark Commits: 237f2d4 by Michal Labedzki (michal.labedzki@xxxxxxxxx): Qt/Bluetooth: Add Device dialog Device dialog appears when user double clicks on device in Devices dialog (Bluetooth->Devices). It provides summary of device, like BD_ADDR, name, timeouts, etc. Base on information from HCI layer, so this feature is more interesting for local devices (capturing on its side). Each field has changes counter, what mean that value at specified field changes in time, for example: user change device name 3 times. Please note that initial change is not counted. It means that you can see fielkd without any value then change occur and counter is not increased. It will be increased next time. Reason for that is in most cases field value is unknown at start. Change-Id: Ife0a6bd454eac00a28f8eb2906e1b395695b0307 Reviewed-on: https://code.wireshark.org/review/15793 Petri-Dish: Michal Labedzki <michal.labedzki@xxxxxxxxx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx> Reviewed-by: Michal Labedzki <michal.labedzki@xxxxxxxxx> Tested-by: Michal Labedzki <michal.labedzki@xxxxxxxxx> Actions performed: from 2df337d Bluetooth HCI (Qt): Remove Q_UNUSED adds 237f2d4 Qt/Bluetooth: Add Device dialog Summary of changes: docbook/release-notes.asciidoc | 1 + epan/dissectors/packet-bluetooth.h | 31 +- epan/dissectors/packet-bthci_cmd.c | 43 +- epan/dissectors/packet-bthci_cmd.h | 31 +- epan/dissectors/packet-bthci_evt.c | 406 +++++++++++- ui/qt/CMakeLists.txt | 3 + ui/qt/Makefile.am | 2 + ui/qt/Makefile.common | 4 + ui/qt/Wireshark.pro | 3 + ui/qt/bluetooth_device_dialog.cpp | 647 ++++++++++++++++++++ ..._devices_dialog.h => bluetooth_device_dialog.h} | 40 +- ui/qt/bluetooth_device_dialog.ui | 277 +++++++++ ui/qt/bluetooth_devices_dialog.cpp | 32 +- ui/qt/bluetooth_devices_dialog.h | 5 +- ui/qt/bluetooth_devices_dialog.ui | 7 + ui/qt/main_window_slots.cpp | 2 +- 16 files changed, 1479 insertions(+), 55 deletions(-) create mode 100644 ui/qt/bluetooth_device_dialog.cpp copy ui/qt/{bluetooth_devices_dialog.h => bluetooth_device_dialog.h} (64%) create mode 100644 ui/qt/bluetooth_device_dialog.ui
- Prev by Date: [Wireshark-commits] master 2df337d: Bluetooth HCI (Qt): Remove Q_UNUSED
- Next by Date: [Wireshark-commits] master 00d36c7: Qt: Expert info grouping.
- Previous by thread: [Wireshark-commits] master 2df337d: Bluetooth HCI (Qt): Remove Q_UNUSED
- Next by thread: [Wireshark-commits] master 00d36c7: Qt: Expert info grouping.
- Index(es):