Wireshark-commits: [Wireshark-commits] master f9be95c: Add a routine to get an array of all instanc

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 6 Jun 2016 01:05:11 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f9be95c4c8ab3484e6cf396e0cf4242b18ff8841
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f9be95c by Guy Harris (guy@xxxxxxxxxxxx):

    Add a routine to get an array of all instances of a string option.
    
    Use it for OPT_COMMENT in the SHB, as there may be ore than one instance
    of OPT_COMMENT in an SHB.
    
    Also, use wtap_optionblock_get_option_string for OPT_SHB_HARDWARE,
    OPT_SHB_OS, and OPT_SHB_USERAPPL; they're specified as "only one
    instance allowed".
    
    Change-Id: I23ad87e41e40b7ae1155e96c0523a6f8caad5204
    Reviewed-on: https://code.wireshark.org/review/15750
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  adee685   Directly use wtap_opttypes calls to fetch SHB options.
    adds  f9be95c   Add a routine to get an array of all instances of a string option.


Summary of changes:
 capinfos.c              |  223 +++++++++++++----------------------------------
 ui/gtk/summary_dlg.c    |   27 +++---
 wiretap/wtap_opttypes.c |   30 +++++++
 wiretap/wtap_opttypes.h |   11 +++
 4 files changed, 118 insertions(+), 173 deletions(-)