Wireshark-commits: [Wireshark-commits] master 6e609d1: mgcp: don't THROW() an exception from a diss

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 31 May 2016 10:35:14 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6e609d1a2b16624effece519559984c6564a4a58
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

6e609d1 by Martin Kaiser (wireshark@xxxxxxxxx):

    mgcp: don't THROW() an exception from a dissector
    
    we can simply abort the dissection for invalid lines or token lengths
    
    Change-Id: I14e02f49a8803db7ec0a5f5c5139705091fd926a
    Reviewed-on: https://code.wireshark.org/review/15628
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ed42a48   mgcp: clean up dissect_mgcp()
    adds  6e609d1   mgcp: don't THROW() an exception from a dissector


Summary of changes:
 epan/dissectors/packet-mgcp.c |    9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)