Wireshark-commits: [Wireshark-commits] master da8a669: Use wtap_optionblock_foreach_option() to get

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 28 May 2016 19:18:37 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=da8a6691e31b37c88f9cd658e27cafa1b6c5d92c
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

da8a669 by Guy Harris (guy@xxxxxxxxxxxx):

    Use wtap_optionblock_foreach_option() to get the SHB options.
    
    That way, we're not assuming that there's one, and only one, of each of
    those options.
    
    That also lets us not have to modify the options to replace linefeeds
    with spaces - we just make a copy of the option string, do the
    replacement, print the modified copy, and free the copy.
    
    Change-Id: I6c51a0a5e70ac01b03b3657a8e2aef39fefcafa6
    Reviewed-on: https://code.wireshark.org/review/15601
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  1095ba3   Qt: Sequence dialog page up+down.
    adds  da8a669   Use wtap_optionblock_foreach_option() to get the SHB options.


Summary of changes:
 capinfos.c |  175 +++++++++++++++++++++++++++++++++++++-----------------------
 1 file changed, 109 insertions(+), 66 deletions(-)