Wireshark-commits: [Wireshark-commits] master-2.0 de78e5e: If we're "[Saving] the file and [closing

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 28 May 2016 18:50:52 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=de78e5e5291ec054d97dc0d5af5871b3524b2f53
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

de78e5e by Guy Harris (guy@xxxxxxxxxxxx):

    If we're "[Saving] the file and [closing] it", actually *close* it.
    
    Otherwise, if you've modified the file (added, removed, or changed
    comments), and you try to close the file or quit, and answer "Save" to
    the "save your work?" question, Wireshark tries to clean up the wmem
    scopes, but the file scope hasn't been left, and wmem crashes with an
    assertion error.
    
    (The GTK+ version does the close, so it doesn't have the bug.)
    
    Change-Id: I87e4bab5017d8cbe693f21b61a19a9fca4625337
    Reviewed-on: https://code.wireshark.org/review/15599
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  d56cf90   Create a "placeholder" NFS CB protocol for ONC-RPC stats.
    adds  de78e5e   If we're "[Saving] the file and [closing] it", actually *close* it.


Summary of changes:
 ui/qt/main_window.cpp |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)