Wireshark-commits: [Wireshark-commits] master b3514e8: Create a "placeholder" NFS CB protocol for O

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 27 May 2016 13:30:53 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b3514e84849fb6a33b8b7dda486ea1774b1b4cc5
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b3514e8 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Create a "placeholder" NFS CB protocol for ONC-RPC stats.
    
    In GTK GUI, "NFS" shows up twice in the ONC-RPC Service Response Time
    Programs list.  That's probably confusing enough to users.  In Qt
    the "second" NFS wasn't showing up at all (or getting overwritten)
    because it was hashing on program name.
    Make NFS programs unique with a "stubbed" protocol.
    
    Bug: 12478
    Change-Id: Ic4ebdab8ba8b70e6026e1fb0f8e8defd4532b0f2
    Reviewed-on: https://code.wireshark.org/review/15587
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  19c0b8b   Don't use "== {TRUE,FALSE}" when testing whether a Boolean is true or false.
    adds  b3514e8   Create a "placeholder" NFS CB protocol for ONC-RPC stats.


Summary of changes:
 epan/dissectors/packet-nfs.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)