Wireshark-commits: [Wireshark-commits] master c0e679e: Cyclic PROFINET PROFIsafe RTC1 data dissecti

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 26 May 2016 12:43:52 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c0e679e0a991103db30bb8d57e8172ab29671884
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c0e679e by T. Scholz (scholzt234@xxxxxxxxxxxxxx):

    Cyclic PROFINET PROFIsafe RTC1 data dissection
    
    New implemented functions for profinet plug-in to read cyclic RTC1 data
    frames more detailed and further to dissect PROFIsafe on PROFINET frames.
    
    New functions include:
    - Reading the PROFINET "Ident OK" Frame for detailed module information,
      as ModuleIdentNr., SubModuleIdentNr., etc. total dynamically
    - Improved the existing dissection of fParameter with usage of GSDML-files,
      as the indexnumber for those parameters can change
    - Reading a GSDML-file for further module-information, such as PROFIsafe
      Module, etc.
    - Aded new pnio protocol preferences, in which the user can define its own
      network path to his GSDML-files, so that Wireshark is able to read those
      files for detailed information output.
    - Added new filter functions for PROFINET and PROFIsafe
    - All gained and saved information will be used to dissect the cyclic
      PROFINET frames
    
    Bug: 12216
    Change-Id: I379da1d349fa099047953042f1aa30450bee5b30
    Reviewed-on: https://code.wireshark.org/review/14119
    Petri-Dish: Jim Young <jim.young.ws@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Birol Capa <birol.capa@xxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  32c1a2a   SMB NtCreate andX with extended response sometimes incorrect
    adds  c0e679e   Cyclic PROFINET PROFIsafe RTC1 data dissection


Summary of changes:
 plugins/profinet/AUTHORS               |    2 +-
 plugins/profinet/CMakeLists.txt        |    1 +
 plugins/profinet/Makefile.common       |    3 +-
 plugins/profinet/packet-dcerpc-pn-io.c |  873 +++++++++++++++++++++----
 plugins/profinet/packet-pn-dcp.c       |   88 ++-
 plugins/profinet/packet-pn-rtc-one.c   | 1093 ++++++++++++++++++++++++++++++++
 plugins/profinet/packet-pn.c           |   11 +
 plugins/profinet/packet-pn.h           |   84 +++
 8 files changed, 2042 insertions(+), 113 deletions(-)
 create mode 100644 plugins/profinet/packet-pn-rtc-one.c