Wireshark-commits: [Wireshark-commits] master 102b216: manolito: use tvb_get_string_enc() for the f

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 17 May 2016 20:34:01 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=102b216a011d9573a013ec8ca936cedfe8505d25
Submitter: Martin Kaiser (wireshark@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

102b216 by Martin Kaiser (wireshark@xxxxxxxxx):

    manolito: use tvb_get_string_enc() for the field name
    
    There's no need to build a string by reading byte-by-byte.
    
    Change-Id: I23223ec1188acbd2591817d66cc8f15d4eb25427
    Reviewed-on: https://code.wireshark.org/review/15486
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    

Actions performed:

    from  55fdbd5   manolito: refactor the message parsing
    adds  102b216   manolito: use tvb_get_string_enc() for the field name


Summary of changes:
 epan/dissectors/packet-manolito.c |    9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)