Wireshark-commits: [Wireshark-commits] master 8c614b8: jxta: there's no need to call proto_tree_set

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 13 May 2016 04:02:11 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8c614b8afb60b9428e704c598ba200fa0188345d
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8c614b8 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    jxta: there's no need to call proto_tree_set_visible() when calling append_text()
    
    It only needs to be called if you're calling proto_tree_append_string().
    
    Change-Id: Ia00c3cb0077469ef6c2eadf98d02569af399fa7d
    Reviewed-on: https://code.wireshark.org/review/15411
    Petri-Dish: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  a1891f6   Add filterable fields for each ISUP number.
    adds  8c614b8   jxta: there's no need to call proto_tree_set_visible() when calling append_text()


Summary of changes:
 epan/dissectors/packet-jxta.c |    3 ---
 1 file changed, 3 deletions(-)