URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f3878c63373b48a5fa321800bf5647342baed2e2
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark
Commits:
f3878c6 by Guy Harris (guy@xxxxxxxxxxxx):
Have the "maybe an FCS" version of the Ethernet dissector take a data argument.
It's called from some places other than packet-frame.c, at least one of
which currently can't call anything else (the ATM dissector, for
VC-multiplexed bridged frames, where you don't know whether the frames
include the FCS or not), so the frame's pseudo-data doesn't necessarily
have the appropriate "FCS length" value. Have it explicitly check the
data argument, and explicitly pass the appropriate value to it.
Change-Id: I0c94e1355e6a0d462c8225bf3831500409984a08
Ping-Bug: 9933
Reviewed-on: https://code.wireshark.org/review/15382
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
Actions performed:
from 057798f Qt: fix loading of profile by command line
adds f3878c6 Have the "maybe an FCS" version of the Ethernet dissector take a data argument.
Summary of changes:
epan/dissectors/packet-atm.c | 16 ++++++++++++++--
epan/dissectors/packet-epon.c | 8 +++++++-
epan/dissectors/packet-eth.c | 12 +++++++-----
epan/dissectors/packet-mim.c | 8 +++++++-
4 files changed, 35 insertions(+), 9 deletions(-)