Wireshark-commits: [Wireshark-commits] master 1dccd1e: Have fvalue_to_string_repr always return an

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 10 May 2016 22:49:43 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1dccd1ee072722fbe6d5e1a9d726a7e87d191f76
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1dccd1e by Michael Mann (mmann78@xxxxxxxxxxxx):

    Have fvalue_to_string_repr always return an (wmem) allocated buffer.
    
    Previous patches converted all fvalue_to_string_repr calls to expect
    an allocated buffer (and not a passed in one).  Now changing signature
    to force an allocated buffer.  Added wmem in case that can be taken
    advantage of within epan (and since the function signature was changing
    anyway).
    
    Change-Id: Ica1ac4a9a182ce0e73303856329e198d9d525b7b
    Reviewed-on: https://code.wireshark.org/review/15343
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  931603c   rawshark: Have fvalue_to_string_repr just return allocated string representation.
    adds  1dccd1e   Have fvalue_to_string_repr always return an (wmem) allocated buffer.


Summary of changes:
 epan/dfilter/dfilter-macro.c |    4 ++--
 epan/dfilter/dfvm.c          |    6 +++---
 epan/ftypes/ftypes.c         |   19 ++++++++++---------
 epan/ftypes/ftypes.h         |   12 ++++--------
 epan/print.c                 |   10 ++++++----
 epan/proto.c                 |   22 +++++++++++-----------
 epan/wslua/wslua_field.c     |   18 +++++++++++-------
 plugins/mate/mate_util.c     |    4 ++--
 rawshark.c                   |    9 ++++-----
 ui/cli/tap-diameter-avp.c    |    4 ++--
 ui/gtk/packet_panes.c        |    4 ++--
 ui/qt/proto_tree.cpp         |    4 ++--
 12 files changed, 59 insertions(+), 57 deletions(-)