Wireshark-commits: [Wireshark-commits] master-1.12 5a43a0c: Don't assume packets will be no larger

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 2 May 2016 00:55:35 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5a43a0c826ba96dd71e9a0dbd051f906806f783b
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

5a43a0c by Guy Harris (guy@xxxxxxxxxxxx):

    Don't assume packets will be no larger than ISERIES_MAX_PACKET_LEN.
    
    We don't check against it.  Insteead, use phdr->caplen as the buffer
    size; that's based on the number of hex digits we've found.
    
    While we're at it, also get rid of ISERIES_PKT_ALLOC_SIZE - it makes it
    less obvious that it's based on the packet length from the packet
    header.
    
    Change-Id: I7a3fac130adc75aa0a4b426cb9b5c9c6279e1c88
    Reviewed-on: https://code.wireshark.org/review/15238
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  713a7bd   Make sure the packet length isn't > WTAP_MAX_PACKET_SIZE.
    adds  5a43a0c   Don't assume packets will be no larger than ISERIES_MAX_PACKET_LEN.


Summary of changes:
 wiretap/iseries.c |   14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)