URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=29c78db2a80a93653f32e4fd2f00b9b550432c43
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
29c78db by Guy Harris (guy@xxxxxxxxxxxx):
Don't treat the packet length as unsigned.
The scanf family of functions are as annoyingly bad at handling unsigned
numbers as strtoul() is - both of them are perfectly willing to accept a
value beginning with a negative sign as an unsigned value. When using
strtoul(), you can compensate for this by explicitly checking for a '-'
as the first character of the string, but you can't do that with
sscanf().
So revert to having pkt_len be signed, and scanning it with %d, but
check for a negative value and fail if we see a negative value.
Change-Id: I6450d468504e942df72342176a0e145e5ac3db5f
Reviewed-on: https://code.wireshark.org/review/15216
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
Actions performed:
from 2cb5985 Make class "type" for USB conversations.
adds 29c78db Don't treat the packet length as unsigned.
Summary of changes:
wiretap/dbs-etherwatch.c | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)