Wireshark-commits: [Wireshark-commits] master bdcc802: ldss: return -1 (not 0) if we need more data

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 1 May 2016 15:41:06 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bdcc802f897462b1ae6f9034b6d91dd9abc4a29c
Submitter: Martin Kaiser (wireshark@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

bdcc802 by Martin Kaiser (wireshark@xxxxxxxxx):

    ldss: return -1 (not 0) if we need more data from TCP
    
    If a dissector returns 0, it rejects the packet ("this is not my
    protocol"). This is in contradiction to requesting more data from TCP.
    
    Bug: 12359
    Change-Id: Ib0da7fc3ef92b35b3950e74f50484d9e21a93a6f
    Reviewed-on: https://code.wireshark.org/review/15198
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    

Actions performed:

    from  dec3fd0   [Automatic update for 2016-05-01]
    adds  bdcc802   ldss: return -1 (not 0) if we need more data from TCP


Summary of changes:
 epan/dissectors/packet-ldss.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)