URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3c5a9b10b4dd6696861a62672b322807bb2bfdf6
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
3c5a9b1 by Gerald Combs (gerald@xxxxxxxxxxxxx):
Qt: Display filter toolbar behavior tweaks.
By default GtkToolbar shows overflow items in a menu. QToolBar shows
them in a bigger toolbar. This is a problem for users with lots of
display filter expressions because expanding the display filter toolbar
can make it very tall.
QToolBar can optionally overflow into a menu, but as noted in
https://bugreports.qt.io/browse/QTBUG-2472 there isn't a way do so
directly, e.g. with a setter. Force an overflow menu in the display
filter toolbar by adding a child QToolBar and adding filter expression
actions to it.
While we're here, set the minimum width of the display filter edit to
two-thirds of the width of the main window.
Change-Id: I49cd58397e087f1aa79b5bbce471f827e9804148
Reviewed-on: https://code.wireshark.org/review/15134
Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
Actions performed:
from c22bf7e uat_dialog (Qt): uat_ can't be NULL here, no need to check it. (CID 1358793)
adds 3c5a9b1 Qt: Display filter toolbar behavior tweaks.
Summary of changes:
ui/qt/main_window.cpp | 12 ++++++++++++
ui/qt/main_window.h | 4 +++-
ui/qt/main_window_slots.cpp | 9 +++++----
3 files changed, 20 insertions(+), 5 deletions(-)