Wireshark-commits: [Wireshark-commits] master 7b2d8a1: Always call test_length(), even if the tree

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 26 Apr 2016 00:34:33 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7b2d8a16c58b9a6a826f2df0f95a5504750493ed
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7b2d8a1 by Guy Harris (guy@xxxxxxxxxxxx):

    Always call test_length(), even if the tree is null.
    
    Otherwise, we run the risk of getting caught in a loop that runs past
    the end of the packet.
    
    Shows up in, for example, the capture in bug 12370; if you read it with
    tshark -V, it reports malformed packets, but if you try to read it with
    tshark without -V, it spins.
    
    Bug: 12370
    Change-Id: Ic3e7be2ddbaaf52b58c4f73348a0f093979af1cc
    Reviewed-on: https://code.wireshark.org/review/15115
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  83a5476   Treat JXTA URI address type like AT_STRINGZ. An "empty" address should still have a size of 1 for NULL string character.
    adds  7b2d8a1   Always call test_length(), even if the tree is null.


Summary of changes:
 epan/proto.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)