URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=71756bd9c7b4c659a861c9b08af57fdd98a4a50a
Submitter: Jeff Morriss (jeff.morriss.ws@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark
Commits:
71756bd by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):
Qt UAT: call the UAT update callback after each field is updated.
This fixes a crash when changing the SCCP dissector's users table when
finishing the edit of a string column by clicking elsewhere (rather than
pressing Enter/Return) or when changing an enum column.
(The SCCP dissector depends on that update callback being called before the
copy callback.)
To do this:
1) Use the editingFinished signal rather than looking for Enter/Return key
presses (so that a focus change is processed as the end of an edit).
2) Call the update callback when an enum field changes.
Bug: 12364
Change-Id: I1884c67b6e873b46afe33703581d0b3dccbbdaf1
Reviewed-on: https://code.wireshark.org/review/15059
Petri-Dish: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
(cherry picked from commit dc3aa26dd3acbe76d4dd91910d03927776db8eb1)
Reviewed-on: https://code.wireshark.org/review/15077
Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
Actions performed:
from 0710dbb [Automatic update for 2016-04-24]
adds 71756bd Qt UAT: call the UAT update callback after each field is updated.
Summary of changes:
ui/qt/uat_dialog.cpp | 18 +++++++++++++++---
1 file changed, 15 insertions(+), 3 deletions(-)