[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3db13a7fc9f08fdb238f06e73a42b39396fee84c
Submitter: João Valverde (j@xxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3db13a7 by João Valverde (joao.valverde@xxxxxxxxxxxxxxxxxx):

    Link version code statically again
    
    This allows keeping the code-sharing with the static linking.
    
    This "fixes" a hypothetical ABI mismatch with wsutil and avoids pulling more
    external dependencies to wsutil than strictly necessary.
    
    A nice side-effect is that libwsutil no longer depends on version.h.
    
    Follow up to f95976eefcbeb5d24df383c29d29ef888b503945.
    
    Change-Id: I8f0d6a557ab3f7ce6f0e2c269124c89f29d6ad23
    Reviewed-on: https://code.wireshark.org/review/15002
    Petri-Dish: João Valverde <j@xxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: João Valverde <j@xxxxxx>
    

Actions performed:

    from  7c6e859   Add "-git" tag to version
    adds  3db13a7   Link version code statically again


Summary of changes:
 .editorconfig                                 |    4 +++
 .gitignore                                    |    2 ++
 CMakeLists.txt                                |    9 ++++++
 Makefile.common                               |   39 ++++++++++++++++---------
 capinfos.c                                    |    2 +-
 captype.c                                     |    2 +-
 configure.ac                                  |    1 +
 debian/libwsutil0.symbols                     |    4 ---
 dumpcap.c                                     |    2 +-
 echld/echld-int.h                             |    2 +-
 editcap.c                                     |    2 +-
 epan/CMakeLists.txt                           |    1 +
 epan/Makefile.am                              |   12 ++++++--
 epan/dissectors/packet-ssl-utils.c            |    2 +-
 epan/print.c                                  |    2 +-
 file.c                                        |    2 +-
 mergecap.c                                    |    2 +-
 rawshark.c                                    |    2 +-
 reordercap.c                                  |    2 +-
 text2pcap.c                                   |    2 +-
 tfshark.c                                     |    2 +-
 tshark.c                                      |    2 +-
 ui/decode_as_utils.c                          |    2 +-
 ui/gtk/about_dlg.c                            |    2 +-
 ui/gtk/file_import_dlg.c                      |    2 +-
 ui/gtk/follow_stream.c                        |    2 +-
 ui/gtk/main.c                                 |    2 +-
 ui/gtk/main_titlebar.c                        |    2 +-
 ui/gtk/main_welcome.c                         |    2 +-
 ui/gtk/summary_dlg.c                          |    2 +-
 ui/qt/about_dialog.cpp                        |    2 +-
 ui/qt/capture_file_properties_dialog.cpp      |    2 +-
 ui/qt/follow_stream_dialog.cpp                |    2 +-
 ui/qt/main_welcome.cpp                        |    2 +-
 ui/qt/main_window.cpp                         |    2 +-
 ui/tap_export_pdu.c                           |    2 +-
 wireshark-qt.cpp                              |    2 +-
 wiretap/CMakeLists.txt                        |    1 +
 wiretap/Makefile.am                           |   11 +++++--
 wiretap/nettrace_3gpp_32_423.c                |    2 +-
 wsutil/ws_version_info.c => ws_version_info.c |    2 +-
 wsutil/ws_version_info.h => ws_version_info.h |   16 +++++-----
 wsutil/.editorconfig                          |    4 ---
 wsutil/CMakeLists.txt                         |    1 -
 wsutil/Makefile.common                        |    6 ++--
 wsutil/Makefile.nmake                         |    5 ++--
 46 files changed, 106 insertions(+), 72 deletions(-)
 rename wsutil/ws_version_info.c => ws_version_info.c (99%)
 rename wsutil/ws_version_info.h => ws_version_info.h (82%)