Wireshark-commits: [Wireshark-commits] master 9a7a54c: RTPS: Added an analysis field to the ACKNACK

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 17 Apr 2016 12:03:24 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9a7a54c0b7d7f76c1f889960f2f183cebc81fb3e
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9a7a54c by Juanjo Martin (juanjo@xxxxxxx):

    RTPS: Added an analysis field to the ACKNACK dissection
    
    A lot of people fail when interpreting ACKNACKs. I added a new field
    that interprets the numeric values and shows a brief sentence with
    the analysis.
    
    Bug: 12312
    
    Change-Id: I89a33f04c52ebd5ca486d2e23bddb7a6646945e7
    Reviewed-on: https://code.wireshark.org/review/14724
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  450c0d5   Improve the message for duplicate dissectors for a protocol.
    adds  9a7a54c   RTPS: Added an analysis field to the ACKNACK dissection


Summary of changes:
 epan/dissectors/packet-rtps.c |   94 +++++++++++++++++++++++++----------------
 1 file changed, 57 insertions(+), 37 deletions(-)