URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8cdc182aff30accec89aa4bef48ff81fad42940b
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
8cdc182 by D. Ulis (daulis0@xxxxxxxxx):
CIP: Attribute updates
1. Switched to common way to parse Get Attr All, using dissect_cip_get_attribute_all_rsp, for CCO (class version) and CIP Validator. This also fixed a missing attribute in the old CIP Validator code.
2. Add cip_string2 attribute implementation
3. For CIP Validator, set the protocol as "CIPS Validator", previously this was "CIPS Supervisor".
4. For classes with subdissectors, add the service to the Info column in the response.
Change-Id: Id9593ca39497261075df8146cf63ee9581462e2a
Reviewed-on: https://code.wireshark.org/review/14837
Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Actions performed:
from 1f90eab Expand before multiply (CID-1355683 and CID-1355684)
adds 8cdc182 CIP: Attribute updates
Summary of changes:
epan/dissectors/packet-cip.c | 46 +++++++++++++++++++++------------
epan/dissectors/packet-cip.h | 4 ++-
epan/dissectors/packet-cipsafety.c | 49 ++++--------------------------------
3 files changed, 38 insertions(+), 61 deletions(-)