Wireshark-commits: [Wireshark-commits] master 445a57b: Make sure conversation exists (CID-280536)

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 26 Mar 2016 22:21:40 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=445a57bdc35f5f09ef878b6bf5a46d7018ddddcc
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

445a57b by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    Make sure conversation exists (CID-280536)
    
    The code sets up a conversation, then proceeds getting it
    and using it. It must be there, so assert that it is before
    dereferencing it.
    
    Change-Id: I5384b9b773a5f4e86f649612ee4f4929a503c523
    Reviewed-on: https://code.wireshark.org/review/14641
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  9dd085d   ethercat: Fix Control flow issues MISSING_BREAK (CID 1357204)
    adds  445a57b   Make sure conversation exists (CID-280536)


Summary of changes:
 epan/dissectors/packet-dcm.c |    2 ++
 1 file changed, 2 insertions(+)